https://bugzilla.redhat.com/show_bug.cgi?id=2097925 --- Comment #2 from Ding-Yi Chen <dchen@xxxxxxxxxx> --- Addressed: BuildRequires: python%{python3_pkgversion}-setuptools ... should be: BuildRequires: python3dist(setuptools) =============================================================== > I would prefer if you use: > install -d -m 0755 directory > instead of -p in the install command install -d treat the rest of the arguments as directories So I cannot replace -p with "-d -m 0755" with files ============================================================ Addressed: also mkdir -p should be install -d -m 0755 .. ============================================================ > I would prefer if you fix setup.py instead installing and removing those scripts and configs. data_files in setup.py does not seem to be capable of rename the files Thus I replace it with ~~~ # Rename configuration files. mv %{buildroot}%{_sysconfdir}/%{name}/cepces.conf{.dist,} mv %{buildroot}%{_sysconfdir}/%{name}/logging.conf{.dist,} ~~~ SPEC: https://download.copr.fedorainfracloud.org/results/dchen/to-be-reviewed/fedora-rawhide-aarch64/04554093-cepces/cepces.spec SRPM: https://download.copr.fedorainfracloud.org/results/dchen/to-be-reviewed/fedora-rawhide-aarch64/04554093-cepces/cepces-0.3.5-2.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2097925 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
