https://bugzilla.redhat.com/show_bug.cgi?id=2099576 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx --- Comment #1 from Cole Robinson <crobinso@xxxxxxxxxx> --- Looks good to me, setting fedora-review+ Some small comments and a few questions below: The Summary: field has trailing whitespace > # libkrun tests require access to "/dev/kvm", which is usually not be available > # not available on build sandboxes. drop the first 'not be available' > # While this project is composed mostly by Rust code, this is not a composed mostly of > # As a result, we can't fully rely on rust-packaging for managing this package. > # Instead, we use some of it's tasks (cargo_prep and cargo_test) and combine it's -> its > # them with using the Makefile provided by the project. We also need to manage > # BuildRequires manually, as rust-packaging gets confused trying to generate > # them dynamically. Not blocking, but: Having to maintain the static BuildRequires list for rust crates is kinda unfortunate. Is it something that could be fixed on rust-packaging side, or more fundamental? If it's fixable it'd be nice to file a bug and reference it here. Also not blocking: Any reason not to ship a pkgconfig file? Vast majority of -devel packages on my machine have one -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2099576 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
