[Bug 2035222] Package Review: wasmedge - High performance WebAssembly Virtual Machine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2035222



--- Comment #27 from dm4@xxxxxxxxxxxxxx ---
(In reply to Fabio Valentini from comment #25)
> Note that the source code also appears to be bundling the C implementation
> of blake3 and some WASI headers.
> 
> Unless those files are not used when compiling WasmEdge, these bundled
> dependencies and their licenses (blake3: ASL 2.0 or CC0; WASI headers: ASL
> 2.0) will need to be specified in the .spec file (i.e. "Provides:
> bundled(blake3) = $version").

Thanks for your advice! We'll update our spec file in the following PR:
https://github.com/WasmEdge/WasmEdge/pull/1578

> > sed -i -e 's/0.0.0-unreleased/%{gittag}/' CMakeLists.txt include/CMakeLists.txt
> 
> Is this really necessary? The release tarball you're using contains a
> VERSION file that specifies exactly the string you need, and this is
> apparently already used by CMake to override the 0.0.0-unreleased version
> string.

Thanks for pointing this out. We fix it in this commit:
https://github.com/WasmEdge/WasmEdge/commit/5744cfe0d2c62c5b242c71214e73827bfe552b23


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2035222
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux