https://bugzilla.redhat.com/show_bug.cgi?id=2097845 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@xxxxxxxxxx Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires: FIX: Use 'perl(:VERSION) >= 5.6.2' instead of 'perl-interpreter >= 0:5.006002' because the package has an epoch. FIX: Please add BRs: coreutils - spec line: 32, 41 make - spec line: 37, 40, 44 sed - spec line: 33 perl(MouseX::Types::Mouse) - lib/MouseX/Types/Common/Numeric.pm:12 perl(Module::Install::Metadata) - Makefile.PL: 6, 7, 10, 11, 14 perl(Module::Install::WriteAll) - Makefile.PL: 16 $ rpm -qp --requires perl-MouseX-Types-Common-0.001000-1.fc37.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(MouseX::Types) 1 perl(MouseX::Types::Mouse) 1 perl(strict) 1 perl(:VERSION) >= 5.6.0 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-MouseX-Types-Common-0.001000-1.fc37.noarch.rpm | sort | uniq -c 1 perl(MouseX::Types::Common) = 0.001000 1 perl-MouseX-Types-Common = 0.001000-1.fc37 1 perl(MouseX::Types::Common::Numeric) = 0.001000 1 perl(MouseX::Types::Common::String) = 0.001000 Binary provides are Ok. $ rpmlint ./perl-MouseX-Types-Common* ================================ rpmlint session starts =============================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 = 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2097845 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
