[Bug 2097746] Review Request: perl-MooseX-Role-WarnOnConflict - Warn if classes override role methods without excluding them

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2097746

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jplesnik@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jplesnik@xxxxxxxxxx
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add 'coreutils', it is needed for macro %{_fixperms}
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST is provided since this version.

$ rpm -qp --requires perl-MooseX-Role-WarnOnConflict-0.01-1.fc37.noarch.rpm |
sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(Moose)
      1 perl(Moose::Exporter)
      1 perl(Moose::Role)
      1 perl(MooseX::Meta::Role::WarnOnConflict)
      1 perl(strict)
      1 perl(warnings)
FIX: Please add following run-time requires:
     perl(Moose::Meta::Role) - lib/MooseX/Meta/Role/WarnOnConflict.pm:6
     perl(Moose::Meta::Role::Application::ToClass) -
lib/MooseX/Role/WarnOnConflict.pm:28

$ rpm -qp --provides perl-MooseX-Role-WarnOnConflict-0.01-1.fc37.noarch.rpm |
sort | uniq -c
      1 perl(MooseX::Meta::Role::WarnOnConflict) = 0.01
      1 perl(MooseX::Role::WarnOnConflict) = 0.01
      1 perl-MooseX-Role-WarnOnConflict = 0.01-1.fc37
Binary provides are Ok.

$ rpmlint ./perl-MooseX-Role-WarnOnConflict*
================================ rpmlint session starts
================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has
taken 0.2 s =
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item.

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2097746
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux