https://bugzilla.redhat.com/show_bug.cgi?id=2095717 --- Comment #8 from Michael J Gruber <mjg@xxxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #2) > Unofficial review: Thanks for your review, which I did not mean to ignore. Due to not receiving bug-mails, I went with the latest review. > Minor comments: > 1) May be helpful to use two line breaks consistently in the commands > section of the spec file and one line break elsewhere. This is consistent now in -2 (one line break; my sections are very short and do not need empty lines within the section). > 2) Enable other architectures on the copr build in addtion to x86_64, it > would be good to have AArch64 and ARM-hfp as described at > https://fedoraproject.org/wiki/Architectures#Primary_Architectures and > linked from > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_architecture_support AArch64 is enabled; ARM-hfp is emulated in copr, and I have mixed experience with that - both in term of runtime as well as reliability. I do run koji scratch builds (for all archs) before any pushes, though. In particular, these use the koji buildroots, not the copr buildroots. > 3) Should Python and Ruby bindings be provided? >From my understanding, they are a very old experiment: They have not been touched since the project moved from sourceforge in 2018, and probably for a very long time before. They are not built with the main project, and the upstream author listed them for removal: https://github.com/mjsottile/sfsexp/issues/15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2095717 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
