https://bugzilla.redhat.com/show_bug.cgi?id=2092180 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gotmax@e.email --- Comment #1 from Maxwell G <gotmax@e.email> --- Here are some comments. - Please use `-p` for all of your install invocations. - You should replace the glob in `%{_bindir}/*` in %files - You need to run the systemd user scriptlets. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units. There's a couple issues with unowned or improperly owned directories. You might want to consult https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ and https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership. - `%{_mandir}/man1/` is wrong, as you don't want to own the whole directory. Just own the actual files (e.g. `%{_mandir}/man1/%{name}.1*`). - Same with `%{_datadir}/bash-completion/completions/`. Both of these directories are already owned by filesystem, so we don't want to own them again here. > %{_datadir}/zsh/site-functions/ - Replace the quoted line with something like this: ``` %dir %{_datadir}/zsh %dir %{_datadir}/zsh/site-functions %{_datadir}/zsh/site-functions/_%{name} ``` It's necessary to own these directories here, because filesystem notably *doesn't* own them. - You probably want to do the same thing (ensure you own both top level directories) for the xdg-desktop-portals file. You can also require xdg-desktop-portals and only own the individual files, but this seems like an optional dependency to me. - You should require dbus-common which owns the dbus service directory and only own the specific file. > %global forgeurl https://gitlab.com/WhyNotHugo/darkman - You can remove this. %gometa should determine %forgeurl automatically. - I believe cobra also generates fish completions. You should be able to add `%{gobuilddir}/bin/darkman completion fish > darkman.fish`, add the appropriate `install` commands to %install, and add ``` %dir %{_datadir}/fish %dir %{_datadir}/fish/vendor_completions.d %{_datadir}/fish/vendor_completions.d/%{name}.fish ``` to %files. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2092180 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
