https://bugzilla.redhat.com/show_bug.cgi?id=2098373 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx --- Comment #1 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Unofficial review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "Unknown or generated", "GNU Lesser General Public License, Version 2.1 [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU Lesser General Public License". 884 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/gearhead2/2098373-gearhead2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package does not use a name that already exists. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gearhead2-textmode , gearhead2-SDL , gearhead2-data , gearhead2-data- gfx [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/jwvhewitt/gearhead-2/archive/86d17e191529733c06d05c333d7f3e820b8645d4/gearhead-2-86d17e191529733c06d05c333d7f3e820b8645d4.tar.gz : CHECKSUM(SHA256) this package : f8fb8fbfce46cec83eca50b6cb577fe14dbee12642181f7434225963e3ef5031 CHECKSUM(SHA256) upstream package : f8fb8fbfce46cec83eca50b6cb577fe14dbee12642181f7434225963e3ef5031 Requires -------- gearhead2 (rpmlib, GLIBC filtered): gearhead2-bin(x86-64) gearhead2-textmode (rpmlib, GLIBC filtered): gearhead2-data gearhead2-SDL (rpmlib, GLIBC filtered): gearhead2-data gearhead2-data-gfx libSDL-1.2.so.0()(64bit) libSDL_image-1.2.so.0()(64bit) libSDL_ttf-2.0.so.0()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) gearhead2-data (rpmlib, GLIBC filtered): gearhead2-data-gfx (rpmlib, GLIBC filtered): font(bitstreamverasans) font(bitstreamverasansmono) gearhead2-data hicolor-icon-theme gearhead2-debuginfo (rpmlib, GLIBC filtered): gearhead2-debugsource (rpmlib, GLIBC filtered): Provides -------- gearhead2: gearhead2 gearhead2(x86-64) gearhead2-textmode: gearhead2-bin(x86-64) gearhead2-textmode gearhead2-textmode(x86-64) gearhead2-SDL: application() application(gearhead2-sdl.desktop) gearhead2-SDL gearhead2-SDL(x86-64) gearhead2-bin(x86-64) metainfo() metainfo(gearhead2-sdl.appdata.xml) gearhead2-data: gearhead2-data gearhead2-data-gfx: gearhead2-data-gfx gearhead2-debuginfo: gearhead2-debuginfo gearhead2-debuginfo(x86-64) gearhead2-debugsource: gearhead2-debugsource gearhead2-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2098373 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ocaml, Python, Haskell, R, Java, C/C++, PHP, SugarActivity, fonts, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: 1) Excluded architecture ARM-hfp https://fedoraproject.org/wiki/Architectures#Primary_Architectures seems ok due to Free Pascal support https://src.fedoraproject.org/rpms/fpc/blob/rawhide/f/fpc.spec 2) May want to have the history.txt file in the documentation 3) Should the testing program cosplay2 also be packaged? It is not necessary, but may help users check system functionality for game support. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2098373 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
