https://bugzilla.redhat.com/show_bug.cgi?id=2048507 Susi Lehtola <susi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to Mark E. Fuller from comment #4) > Thank you for the review - here are the updated files: > SPEC: https://fuller.fedorapeople.org/python-molmass.spec > SRPM: https://fuller.fedorapeople.org/python-molmass-2021.6.18-1.fc36.src.rpm > > I corrected the line endings and also removed the shebang inside the spec > with dos2unix and sed (added to BuildRequires) > Is this an acceptable approach over using patching? Yes. The problem with sed is that you won't get notified if the command stops working with a new release; however, line endings and shebangs aren't critical issues and sed is fine. To keep the time stamp of molmass_web, use e.g. sed s/#!.*$// molmass/molmass_web.py > molmass/molmass_web.py.noenv && touch -r molmass/molmass_web.py molmass/molmass_web.py.noenv && mv molmass/molmass_web.py.noenv molmass/molmass_web.py With this change, the package has been APPROVED by jussilehtola. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2048507 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
