https://bugzilla.redhat.com/show_bug.cgi?id=2095717 --- Comment #4 from Michael J Gruber <mjg@xxxxxxxxxxxxxxxxx> --- (In reply to Ian McInerney from comment #3) Thanks for the detailed review and for raising the right questions at the right places! I almost missed it because bz decided not to put the reporter (me) on the cc list. Weird. I have the spec file for 1.4.0-2 pending (unless you prefer to accumulate everything into 1.4.0-1, which is fine for me). > Issues: > - Must include the perl executable (e.g. BuildRequires: perl-interpreter) as > a build dependency because the test script uses perl done > - Replace $RPM_BUILD_ROOT with %{buildroot} done > - Don't glob the .so file in the main files section (instead hardcode the > soname information) I've seen this a lot, but not globbing this makes soname changes more obvious. Done > - %{?ldconfig_scriptlets} is not needed unless building on EPEL7 done > - Include the LICENSE_LGPL file in the installation (the COPYING file says > the user should receive a copy of the LPGL, which is in this file) It is not shipped in the distribution tarball (only in the github-generated one). I have asked upstream to change this: https://github.com/mjsottile/sfsexp/pull/20 But only a new automake run and release will make the distribution tarball contain the file. Should I simply ship the file as an additional "source" for now? > - The Fedora shortname for the License field here would be LGPLv2+ instead > of LGPL-2.1+ (as shown here > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses). > > I am also blocking on a legal query because this package appears to place a > restriction on the LGPL about derivative works > (https://lists.fedoraproject.org/archives/list/legal@xxxxxxxxxxxxxxxxxxxxxxx/ > thread/EN7FJDUNEGTMHW2ZYZ4GYNFAC75ZKMV3/) I guess I looked at the wrong column. Changed to LGPLv2+ for now but waiting for legal's final verdict on this -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2095717 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
