https://bugzilla.redhat.com/show_bug.cgi?id=2082032 --- Comment #4 from Ewoud Kohl van Wijngaarden <ekohlvan@xxxxxxxxxx> --- (In reply to Christoph Erhardt from comment #3) > The package looks in good shape, so I'm giving it a 'review (+)'. Thanks, I appreciate that. I'll address your comments in the final push. > I have two minor nits, which I consider optional: > - The `%description` text should end with a full stop (.), not with an > ellipsis > (...). Will do. > - The package ships the `tests` subdirectory, which seems unnecessary - the > tests are only needed at build time. I agree with you here. They are included via the %pyproject_save_files macro, but I couldn't find an easy way to have it exclude the tests module so the only thing I can come up with is to add %exclude %{python3_sitelib}/PyGitUp/tests to the %files section. That does work. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2082032 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
