https://bugzilla.redhat.com/show_bug.cgi?id=2086484 --- Comment #12 from Carl George 🤠 <carl@xxxxxxxxxx> --- This is looking real good. We do still need to put the finishing touches on the documentation/license handling. I just realized this spec is doing something that is forbidden in the guidelines [0]. > Marking a relative path with %doc in the %files section will cause RPM to copy the referenced file or directory from %_builddir to the proper location for documentation. Files can also be placed in %_pkgdocdir, and the build scripts of the software being packaged may do this automatically when called in %install. However, mixing these methods is problematic and may result in duplicated or conflicting files, so use of %doc with relative paths and installation of files directly into %_pkgdocdir in the same source package is forbidden. The upstream Makefile is installing the files into %{buildroot}%{_pkgdocdir}, then %doc is doing it again. This is also why we run into issues not listing all the files as %doc. What we should do is rm INSTALL.md and LICENSE.md from %{_pkgdocdir} during %install (right after %make_install), then only list %{_pkgdocdir} in %files, removing all %doc lines with relative paths. I tried this and it worked, except it needed one more tweak to resolve an "ambiguous python shebang" error (this can probably be fixed upstream). %{make_install} +rm %{buildroot}%{_pkgdocdir}/INSTALL.md %{buildroot}%{_pkgdocdir}/LICENSE.md +sed -e '1 s/python/python3/' -i %{buildroot}%{_pkgdocdir}/keybase/keybase.py %license LICENSE.md -%doc LICENSE.md -%doc AUTHORS.md ChangeLog.md INSTALL.md README.md SECURITY.md -%doc docs/CODE_OF_CONDUCT.md docs/CONTRIBUTING.md -%doc docs/*.txt -%doc docs/*.html -%doc docs/mime.types -%doc contrib/account-command -%doc contrib/colorschemes -%doc contrib/hcache-bench -%doc contrib/keybase -%doc contrib/logo -%doc contrib/lua -%doc contrib/samples -%doc contrib/vim-keys -%doc contrib/oauth2 +%{_pkgdocdir} [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2086484 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
