[Bug 2095717] Review Request: sfsexp - Small Fast S-Expression Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2095717

Ian McInerney <ian.s.mcinerney@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian.s.mcinerney@xxxxxxxx
             Status|NEW                         |ASSIGNED
           Doc Type|---                         |If docs needed, set a value
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |ian.s.mcinerney@xxxxxxxx



--- Comment #1 from Ian McInerney <ian.s.mcinerney@xxxxxxxx> ---
I'll review this over the weekend. At first glance at the specfile though, it
appears you are globbing the soversion of the library. I would suggest not
globbing the soversion and instead adding a global variable to contain it. That
way it is obvious when there is an soversion bump and dependent packages need
to be rebuilt. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2095717
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux