[Bug 2022555] Review Request: lv2-eq10q - LV2 audio plugin suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2022555

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(code@musicinmybra |
                   |in.net)                     |



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
It looks like it has a missing dependency PStreams[1]:

> No matching package to install: 'pstreams-devel'

This was in Fedora[2] but was orphaned and retired. It would need to be
unretired[3]. It’s a simple enough package, but it would need a few changes,
such as, at a quick skim of the spec file:

- It should have been packaged like other header-only libraries[4], in that the
source package should have been called pstreams, with a binary package called
pstreams-devel, rather than calling the source package pstreams-devel. This
means it would actually be a combined unretirement and renaming, and the
original dist-git repository wouldn’t be unretired.
- The spec file should use %make_build/%make_install macros and should run the
tests.
- The Source0 URL can/should be HTTPS
- The Doxygen-generated HTML documentation shouldn’t be packaged, or should be
generated as a PDF, due to guidelines issues with bundled and pre-compiled
JS/CSS[5].

I can help or answer questions on any of this.

[1] http://pstreams.sourceforge.net/
[2] https://src.fedoraproject.org/rpms/pstreams-devel/
[3]
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming
[4]
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries
[5] https://bugzilla.redhat.com/show_bug.cgi?id=2006555


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2022555
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux