https://bugzilla.redhat.com/show_bug.cgi?id=2093465 --- Comment #1 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Spec is correct, but before approving it two questions: - Wouldn't it better to call package directly `gmailctl` rather than `golang-github-mbrt-gmailctl`? If you want so, define the following global: %global goname gmailctl Rename the spec to gmailctl.spec and change this BZ's title. You can check `doctl` as an example. - You defined all the BuildRequires rather than using `%go_generate_buildrequires`. In some of your other specs you're using that macro, maybe you want to change this spec to use dynamic BuildRequires? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2093465 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
