https://bugzilla.redhat.com/show_bug.cgi?id=2092965 Sergio Lopez <slopezpa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(slopezpa@redhat.c | |om) | --- Comment #2 from Sergio Lopez <slopezpa@xxxxxxxxxx> --- (In reply to Cole Robinson from comment #1) > Before the kernel `Source:` line can you add a comment that bundling of the > kernel package was approved by fedora kernel maintainers, and link to the > discussion: > https://lists.fedorahosted.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx/ > thread/2TMXPCE2VWF7USZA7OHQ3P2SBJAEGCSX/ > > * Add a comment explaining the exclusivearch. `package only buildable for > $ARCHES` is enough IMO > > * Typo 'pacakge' > * Use %make_install PREFIX=%{_prefix} > > BuildRequires: I see the list is copied from kernel distgit but a lot of > that is redundant and possibly not even used with your libkrunfw config. > First you can remove everything that's explicitly listed in the buildroot: > https://pagure.io/fedora-comps/blob/main/f/comps-f37.xml.in#_324 For a f36 > x86_64 build I got it down to: > > # libkrunfw + packaging requirements > BuildRequires: gcc > BuildRequires: git-core > BuildRequires: make > BuildRequires: python3-pyelftools > > # kernel build requirements > BuildRequires: bison > BuildRequires: flex > BuildRequires: bc > BuildRequires: elfutils-devel > > But no runtime testing, and I didn't try dropping bison+flex+bc, I just saw > they were in build output. You nailed the required packages, I've tried removing "bison", "flex" and "bc" individually and all of them are required. We also need "perl-interpreter" on aarch64. I've produced a new COPR build with the new spec. I think I've applied all your suggestions, please let me know if I missed something: - https://download.copr.fedorainfracloud.org/results/slp/libkrunfw/fedora-rawhide-x86_64/04501528-libkrunfw/libkrunfw.spec - https://download.copr.fedorainfracloud.org/results/slp/libkrunfw/fedora-rawhide-x86_64/04501528-libkrunfw/libkrunfw-2.1.1-1.fc37.src.rpm Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2092965 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
