https://bugzilla.redhat.com/show_bug.cgi?id=2087264 --- Comment #3 from Gustavo Costa <xfgusta@xxxxxxxxx> --- Hi Benson. Thanks for the unofficial review. > 1) Perhaps change > BuildRequires: /usr/bin/setfacl > to > BuildRequires: acl > as setfacl is provided by https://packages.fedoraproject.org/pkgs/acl/acl/ Done! > 2) Should header files be in a devel package? See > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages As you've already noticed, the bfs package doesn't provide any header files or library. > 3) Would be helpful to explicitly use %{_mandir}/man1/%{name}.1.gz rather > than %{_mandir}/man1/%{name}.1* This is the correct way. RPM will re-compress it into its preferred format when installing the man page [1] 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087264 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
