https://bugzilla.redhat.com/show_bug.cgi?id=2092965 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? | |needinfo?(slopezpa@redhat.c | |om) Status|NEW |ASSIGNED --- Comment #1 from Cole Robinson <crobinso@xxxxxxxxxx> --- Before the kernel `Source:` line can you add a comment that bundling of the kernel package was approved by fedora kernel maintainers, and link to the discussion: https://lists.fedorahosted.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx/thread/2TMXPCE2VWF7USZA7OHQ3P2SBJAEGCSX/ * Add a comment explaining the exclusivearch. `package only buildable for $ARCHES` is enough IMO * Typo 'pacakge' * Use %make_install PREFIX=%{_prefix} BuildRequires: I see the list is copied from kernel distgit but a lot of that is redundant and possibly not even used with your libkrunfw config. First you can remove everything that's explicitly listed in the buildroot: https://pagure.io/fedora-comps/blob/main/f/comps-f37.xml.in#_324 For a f36 x86_64 build I got it down to: # libkrunfw + packaging requirements BuildRequires: gcc BuildRequires: git-core BuildRequires: make BuildRequires: python3-pyelftools # kernel build requirements BuildRequires: bison BuildRequires: flex BuildRequires: bc BuildRequires: elfutils-devel But no runtime testing, and I didn't try dropping bison+flex+bc, I just saw they were in build output. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2092965 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
