https://bugzilla.redhat.com/show_bug.cgi?id=2091282 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Unofficial review Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Mozilla Public License 1.1 GNU General Public License v2.0 or later GNU General Public License (v2 or later) or GNU Lesser General Public License (v2.1 or later)", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "*No copyright* Mozilla Public License 1.1", "*No copyright* Apache License 2.0", "*No copyright* GNU General Public License Apache License". 4 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/sfnt2woff- zopfli/2091282-sfnt2woff-zopfli/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: sfnt2woff-zopfli (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package does not use a name that already exists. Note: Couldn't connect to Pagure, check manually [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/bramstein/sfnt2woff-zopfli/archive/v1.3.1/sfnt2woff-zopfli-1.3.1.tar.gz : CHECKSUM(SHA256) this package : 1cc0414cf524e14bdfacab4ab1cdefd596a2023ea133e224f9d54566ef8b2a75 CHECKSUM(SHA256) upstream package : 1cc0414cf524e14bdfacab4ab1cdefd596a2023ea133e224f9d54566ef8b2a75 Requires -------- sfnt2woff-zopfli (rpmlib, GLIBC filtered): libc.so.6()(64bit) libz.so.1()(64bit) libzopfli.so.1()(64bit) rtld(GNU_HASH) sfnt2woff-zopfli-debuginfo (rpmlib, GLIBC filtered): sfnt2woff-zopfli-debugsource (rpmlib, GLIBC filtered): Provides -------- sfnt2woff-zopfli: sfnt2woff-zopfli sfnt2woff-zopfli(x86-64) sfnt2woff-zopfli-debuginfo: debuginfo(build-id) sfnt2woff-zopfli-debuginfo sfnt2woff-zopfli-debuginfo(x86-64) sfnt2woff-zopfli-debugsource: sfnt2woff-zopfli-debugsource sfnt2woff-zopfli-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2091282 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, fonts, Haskell, Ocaml, Perl, Java, SugarActivity, PHP, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: 1) Seems good to me. 2) The url http://people.mozilla.org/~jkew/woff/ seems not to be available. Code seems to be available at https://web.archive.org/web/20170630235618/https://people-mozilla.org/~jkew/woff/ as indicated at https://github.com/TheJessieKirk/sfnt2woff . 3) Descriptions at https://packages.fedoraproject.org/pkgs/woff2/woff2-tools/ and https://launchpad.net/ubuntu/bionic/+package/woff-tools , indicate both compression and decompression executables are available, maybe the description could be updated to indicate this as the name of the package suggests only compression is possible, though decompression only seems to be to stdout. 4) Fedora does not recommend packaging WOFF fonts https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_web_fonts 5) WOFF2 https://www.w3.org/TR/WOFF2/ is available and may compress better. Some of the implementations listed at https://www.w3.org/Fonts/WG/WOFF2/Implementation.html have been packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2091282 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
