https://bugzilla.redhat.com/show_bug.cgi?id=2092637 --- Comment #2 from Major Hayden 🤠 <mhayden@xxxxxxxxxx> --- (In reply to Benson Muite from comment #1) > FURTHER COMMENTS > 1) Can > rm -f %{buildroot}%{_bindir}/fixup*.py > be replaced by > rm -f %{buildroot}%{_bindir}/fixup_pubsub_v1_keywords.py > to indicate the specific file being removed Fixed that. I had copied that over from another spec while I was testing this one. > 2) A copr build would be helpful to verify it works on more architectures Done! https://copr.fedorainfracloud.org/coprs/mhayden/python-google-cloud/build/4490687/ > 3) Is libcst needed for extras? Fixed. > 4) Seems not compatible with Fedora 35: > https://github.com/googleapis/python-pubsub/blob/main/setup.py#L36 > https://packages.fedoraproject.org/pkgs/python-google-api-core/python3- > google-api-core/ Yes, there's an ongoing issue in F35 right now that has something to do with protobuf, proto-plus, or iam-v1. I've been talking to the folks in #fedora-python to hunt that down. > 5) There is more documentation at > https://github.com/googleapis/python-pubsub/tree/main/docs which is also > online at https://cloud.google.com/python/docs/reference/pubsub/latest > though the README provides basic information, so this need not be packaged. I was packaging the docs previously for these google cloud packages, but then I ended up in some challenging situations with sphinx trying to refer to other bits of documentation that it couldn't reach during an RPM build. SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/04490687-python-google-cloud-pubsub/python-google-cloud-pubsub-2.12.1-1.fc37.src.rpm Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/04490687-python-google-cloud-pubsub/python-google-cloud-pubsub.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2092637 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
