Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gimp-lqr-plugin - GIMP LiquidRescale Plug-In https://bugzilla.redhat.com/show_bug.cgi?id=314871 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-10 11:22 EST ------- (In reply to comment #7) > It builds OK on my rawhide machine, i386. Am I doing something wrong? You actually modified your spec file :) --------------------------------------------------- @@ -11,7 +8,7 @@ Source0: http://liquidrescale.wikidot.com/local--files/en:download-page/%{name}-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-%(%{__id_u} -n) -BuildRequires: gimp, gimp-devel >= 2.2.13, perl-XML-Parser +BuildRequires: gimp, gimp-devel >= 2.2.13, perl-XML-Parser, gettext Requires: gimp >= 2.2.13, perl-XML-Parser %description --------------------------------------------------- Now your srpm builds. http://koji.fedoraproject.org/koji/taskinfo?taskID=285397 ! Note - From next time please change the release number of your spec file every time you modify your spec file. For 0.3.0-1.fc9: * Perl modules dependency c.f. http://fedoraproject.org/wiki/Packaging/Perl - When writing perl modules dependency, please write the module name as dependency, not writing the rpm name directly, for example: --------------------------------------------------- BuildRequires: perl(XML::Parser) * Tarball, versioning - The written Source0 tarball could not found. Instead I found http://liquidrescale.wikidot.com/local--files/en:download-page/gimp-lqr-plugin-0.3.0-6.tar.gz Umm... In this case, we regard the version as "0.3.0.6" as rpm "Version" does not accept hyphen. * CFLAGS ---------------------------------------------------- make %{?_smp_mflags} CFLAGS="%{optflags}" ---------------------------------------------------- - Please check if this CFLAGS is really needed. %configure sets CFLAGS as environ (check what %configure actually does by `rpm --eval %configure`) and most recent Makefiles treats this properly. * Timestamps - Please check if the following method keeps timestamps on installed files ---------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ---------------------------------------------------- While sometimes this does not work, this usually works on recent Makefiles. * Documents - Please add the following documents to %doc. ---------------------------------------------------- AUTHORS NEWS ---------------------------------------------------- * Directory ownership issue: - Please consider the ownership issue of directories. ---------------------------------------------------- %files %{_datadir}/gimp-lqr-plugin/help/en/gimp-help.xml %{_datadir}/gimp-lqr-plugin/help/en/index.html %{_datadir}/gimp-lqr-plugin/help/images/dialog1.png %{_datadir}/gimp-lqr-plugin/help/images/dialog2.png ....... ---------------------------------------------------- This causes the following problem, for example. ---------------------------------------------------- [tasaka1@localhost ~]$ rpm -qf /usr/share/gimp-lqr-plugin/help/en/index.html gimp-lqr-plugin-0.3.0-1.fc9 [tasaka1@localhost ~]$ rpm -qf /usr/share/gimp-lqr-plugin/help/en/ file /usr/share/gimp-lqr-plugin/help/en is not owned by any package [tasaka1@localhost ~]$ rpm -qf /usr/share/gimp-lqr-plugin/help/ file /usr/share/gimp-lqr-plugin/help is not owned by any package [tasaka1@localhost ~]$ rpm -qf /usr/share/gimp-lqr-plugin/ file /usr/share/gimp-lqr-plugin is not owned by any package ---------------------------------------------------- Here - Installing gimp-lpr-plugin binary rpm creates the directories /usr/share/gimp-lpr-plugin, .../help, .../help/en to install index.html under the last directory - But these directories left unowned by any package. This autually causes some problems. ! Note - When we write ------------------------------------------------------ %files %{_datadir}/gimp-lqr-plugin/ ------------------------------------------------------ This contains the directory %_datadir/gimp-lpr-plugin itself _and_ all files/directories/etc under %_datadir/gimp-lpr-plugin, where ------------------------------------------------------ %files %dir %{_datadir}/gimp-lqr-plugin/ ------------------------------------------------------ contains the directory %_datadir/gimp-lqr-plugin only. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review