https://bugzilla.redhat.com/show_bug.cgi?id=2085377 --- Comment #10 from Dan Horák <dan@xxxxxxxx> --- (In reply to jschmidb from comment #8) > Hi Dan, > > ok, I changed the License tag to just MIT. Will open a pr for this. > > After changing the %prep to %autosetup, I get an rpm build error, so I left > this as > "%setup -q -n %{name}" for now. > > Comparing the tar.gz archives shows that I in fact included the .git and > build folders, which > is probably not what you want. I rebuilt the rpm without these two folders > and I'm attaching > the new rpm to this bugzilla. The source rpm must include the source archive downloaded from github, as referred by the Source0 tag. I guess you are building the source archive locally. The reviewed source rpm must include the source archive that matches the one from the Source0, otherwise we are possibly reviewing something completely different. > You also mentioned: "there is no %files section for the static library" > The %files section has this entry: > %{_libdir}/%{name}.so > What else do we need here? There is a %package section for the static subpackage, but no corresponding %files section. As a result the libzpc.a static library is not distributed. And as mentioned in my comment #7, the *.so file belongs to the devel subpackage and the *.so.* file into the main package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2085377 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
