https://bugzilla.redhat.com/show_bug.cgi?id=2091291 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |ASSIGNED --- Comment #3 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Much better now! I'll approve the package review, but there is one extra thing you may want to check and another issue(?) you'll need to solve: - All the content from examples is being installed, not sure if the Vagrant and init files make sense to be installed. If you think that's required, I'll suggest to create a doc subpackage, otherwise a rm of those folders or not including `examples` at all are other options. - A package called nebula existed in the past for Fedora, not sure how to deal with it. fedora-review is correct: - The specfile is sane - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID) Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2091291 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
