https://bugzilla.redhat.com/show_bug.cgi?id=2081539 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #13 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- For the Release and %changelog fields, I'd strongly suggest %autorelease and %autochangelog. It is optional, but it'll save you a lot of typing during package updates. (This goes against the request by Parag to do changelog entries doing devel, sorry.) [1] https://docs.pagure.org/fedora-infra.rpmautospec/principle.html The text in %description should either be wrapped to <=80 columns, or not at all. 'rpm -qi' will line-break the text, so if there line-breaks within paragraphs, the text becomes jagged. (See e.g. 'rpm -qpi results/vazirmatn-rd-fonts-32.101-2.fc37.noarch.rpm'.) The %description texts all have an extra empty newline at the top. Please add a backslash everywhere, e.g.: - %global fontdescription0 %{expand: + %global fontdescription0 %{expand:\ So… the %description is actually not very useful to the user, because they don't care about development history and the build process is managed by you (the maintainer). The description should just say what the font is. Something like "This package provides a simple and legible typeface originally intended for for web pages and applications, but suitable for all uses. It provides full coverage of … and is characterized by ….". Generally, this is a place to advertise the package a bit, i.e. list the good things that the user might care about. I installed the font and it seems to show up properly and looks fine. But I can't read it, so that doesn't mean too much. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2081539 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
