[Bug 2089880] Review Request: json-fortran - A Modern Fortran JSON API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2089880



--- Comment #2 from Susi Lehtola <susi.lehtola@xxxxxx> ---
Thanks for the review!

(In reply to Mark E. Fuller from comment #1)
> The review caught a couple items about the directory structure that are new
> to me and that I want to check on (feel free to comment since you have a lot
> more experience here than me):
> [ ]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/lib64/gfortran
> [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/lib64/gfortran,
>      /usr/lib64/gfortran/modules
> 
> Other than that, everything looks great

The packaging guidelines say that this is where Fortran modules must be
installed

https://docs.fedoraproject.org/en-US/packaging-guidelines/Fortran/

which is owned by gcc-gfortran. I switched to using the %_fmoddir macro and
requiring gcc-gfortran in -devel.

https://jussilehtola.fedorapeople.org/json-fortran.spec
https://jussilehtola.fedorapeople.org/json-fortran-8.3.0-2.fc36.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2089880
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux