[Bug 2084529] Review Request: python-flask-mod-auth-gssapi - A Flask extention to make use of the authentication provided by the mod_auth_gssapi extention of Apache's HTTPd.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2084529

Maxwell G <gotmax@e.email> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |gotmax@e.email



--- Comment #1 from Maxwell G <gotmax@e.email> ---
> %global debug_package %{nil}

- This is redundant for noarch packages.

> Requires: python3-flask
> Requires: python3-gssapi

- The python dependency generator should handle this.

> rm -rf $RPM_BUILD_ROOT

- This is no longer necessary.

> %doc config/gssproxy.conf
> %doc config/systemd-httpd-service.conf
> %doc config/httpd.conf
> %doc config/tmpfiles.conf

- Why don't you shorten this to `%doc config` or better yet install the conf
files to the proper location?

- Is it possible to run the tests? If not, you should at least run
`%py3_check_import flask_mod_auth_gssapi`.

- You might want to consider porting this specfile to use the new
pyproject-rpm-macros, but this isn't a hard requirement.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2084529
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux