[Bug 2086299] Review Request: ansible-collection-community-libvirt - Manages virtual machines supported by libvirt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2086299

Maxwell G <gotmax@e.email> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #13 from Maxwell G <gotmax@e.email> ---
(In reply to Paul Howarth from comment #12)
> I figured out what was going on with the %{ansible_collection_url} on the
> SRPM for the EPEL-9 build. The SRPM is normally generated using the minimal
> buildroot, which does not contain ansible-packaging and hence a definition
> of %{ansible_collection_url}. The macro gets expanded for the Fedora build
> because it uses dynamic buildrequires and so the SRPM is regenerated with
> ansible-packaging present. The normal way to address this would be to have
> an ansible-srpm-macros package that contained the definition of
> %{ansible_collection_url} and have redhat-rpm-config (and the equivalent
> package for EPEL) require ansible-srpm-macros, which would pull it into the
> minimal buildroot for the SRPM build. For now though I worked around it by
> using %generate_buildrequires unconditionally. If there's ever a need to
> support EPEL prior to 9, that could be done in a different way in the
> appropriate branch.

Thanks for figuring this out! I have made the appropriate changes to
ansible-packaging to split out that macro into ansible-srpm-macros and am
waiting on my PRs to redhat-rpm-config and epel-rpm-macros that adds that new
package to the buildroot to be approved. I would like this package in epel8,
but we shouldn't need this workaround for too long.

If you could add me (@gotmax23) as an admin to the package when you import it,
I would appreciate it.

Anyways, this package is approved!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2086299
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux