[Bug 2058961] Review Request: python-unicodedata2 - Unicodedata backport updated to the latest Unicode version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2058961



--- Comment #7 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
I'd do the following changes.

@@ -13,7 +13,6 @@

 BuildRequires:  gcc
 BuildRequires:  python3-devel
-BuildRequires:  python3dist(coverage)
 BuildRequires:  python3dist(pytest)
 BuildRequires:  python3dist(pytest-randomly)
 BuildRequires:  python3dist(pytest-xdist)
@@ -50,7 +49,7 @@
 %py3_install

 %check
-PYTHONPATH=%{buildroot}%{python3_sitearch} %{__python3} -m pytest -v
+%pytest -v

 %files -n python3-%{pypi_name}
 %license LICENSE


1) coverage appears unused and is discouraged in
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters
2) %pytest somehow looks easier and does not add $PWD to sys.path


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2058961
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux