https://bugzilla.redhat.com/show_bug.cgi?id=2086472 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #6 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Some feedback: 1) %python_provide is deprecated, why have you added it? 2) rm -rf %{pypi_name}.egg-info is not needed 3) BuildRequires: python3-rpm-macros is never needed 4) %exclude %{python3_sitelib}/test should be fixed upstream (as well) 5) The specfile defines and uses %{pypi_name}, but the summary and description is repeated literally, which seems rather inconsistent 6) The release tag needs %dist, see https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ Also, consider using the modern Python packaging guidelines instead: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2086472 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
