Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: phpwapmail - WAP-based e-mail client https://bugzilla.redhat.com/show_bug.cgi?id=402821 ------- Additional Comments From limb@xxxxxxxxxxxx 2007-12-09 21:32 EST ------- > It seems some kind of too extra requirement... :) I prefer to not follow it, > because I try to create .spec files "good readable" under uncient Linux console > or even a dumb terminal. Using 4-space steps for indentation is good for this > purpose. And then I prefer to use "one tab" instead of "8 spaces" for the > "two-step" indentation... It's not telling you which to use, it wants you to use 1 or the other. The error tells you the first place you have a tab if the first part has spaces, or vice versa. Very helpful in fixing it, actually. > This package is intended for using under Apache and mod_php, i.e. "httpd"+"php" > Try rpmlint for the current "httpd" package. Your comments?... :) Agreed. I say leave it alone, like I did in some of my packages for webapps. :) > Yep, it is for security. Agreed. > I cannot reproduce this... Could you obtain a full "sed" command string? (For > example, re-build the package under your environment, adding "echo" before the > "sed" command. This way the full "sed" command string will be just printed, not > executed, and we'll see whats going on...) On the second install, it didn't occur, so I commented out the if block. I got this: sed -i -e /$SECRET = "";/ s/"";/"Mb0j4md+4azjZMCB"; # Autogenerated for fawkes.local/ /etc/phpwapmail/config.php Afterward, I uncommented and tried again and it's fine. Tried it on another machine in case it was a fresh install issue, no luck. Never mind. I'll proceed. . . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review