[Bug 2086299] Review Request: ansible-collection-community-libvirt - Manages virtual machines supported by libvirt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2086299



--- Comment #2 from Maxwell G <gotmax@e.email> ---
> # Avoid inclusion of package note file
> %undefine _package_note_file

I don't think this is necessary. There are no binaries built.

I would recommend mentioning that it's an ansible collection somewhere in the
`Summary:`/`%description`. You can take a look at
https://src.fedoraproject.org/rpms/ansible-collection-community-docker/blob/rawhide/f/ansible-collection-community-docker.spec
which I maintain for an example. This is admittedly a bit of a nitpick.

I also attached a patch to change the way that the specfile handles removing
unnecessary files and enables unit tests. I would like to eventually add a
macro to ansible-packaging that automates running unit tests for ansible
collections. I will look into writing packaging guidelines, as well.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2086299
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux