https://bugzilla.redhat.com/show_bug.cgi?id=2086265 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > mkdir -p $RPM_BUILD_ROOT%{_datadir}/budgie/wm-properties > rm -rf $RPM_BUILD_ROOT%{_datadir}/budgie/autostart > rm -rf $RPM_BUILD_ROOT%{_datadir}/budgie/cursor-fonts > chrpath --delete $RPM_BUILD_ROOT%{_bindir}/budgie-control-center Please use "%{buildroot}" instead of "$RPM_BUILD_ROOT". The former is an RPM macro and the latter is a shell variable and macros are preferred here. > %{_datadir}/applications/*.desktop Please add a %check section and validate all desktop files with desktop-file-validate. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage > %{_datadir}/metainfo/budgie-control-center.appdata.xml Same guidance as for desktop files. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2086265 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
