https://bugzilla.redhat.com/show_bug.cgi?id=2080701 marcdeop@xxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |marcdeop@xxxxxxxxxxxxxxxxx --- Comment #1 from marcdeop@xxxxxxxxxxxxxxxxx --- A few things: - BuildRequires: cmake(KF5Declarative) <--- is duplicated - There is no need to use _description - Instead of %{_kf5_archdatadir}/qml/ you can use %{_kf5_qmldir} - Some lines like Summary or URL are not properly aligned ( yes, it's nitpicking but.. ;-) ) - I would personally use for Summary: "Making tiling window management easy. On KDE Plasma." - Do we want -DCMAKE_BUILD_TYPE=RelWithDebInfo ? Our cmake_kf5 macro uses "release"... - Question: why "%{_kf5_datadir}/icons/hicolor/16x16/status/%{name}*" and not "%{_kf5_datadir}/icons/hicolor/16x16/status/*" ? (adding the %{name} feels unnecessary) - The lines with files in "%{_kf5_datadir}/kconf_update/" can be replace with a single "%{_kf5_datadir}/kconf_update/*" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2080701 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
