https://bugzilla.redhat.com/show_bug.cgi?id=2081432 --- Comment #4 from Pino Toscano <ptoscano@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #3) > Spec review notes: > > > %setup -q -n %{name} > > %setup -q -a 1 -n %{name} > > This can be collapsed to a single macro: "%autosetup -n %{name} -a 1". As it > currently stands, the second command is redoing the first command. :) Makes sense. > > appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/metainfo/* > > desktop-file-validate %{buildroot}/%{_datadir}/applications/* > > Please move these to %check. I can do, seems harmless. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ seems to suggest it can be either in %install or %check. Since the build system of subscription-manager-cockpit is based/derived on cockpit' starter-kit, I submitted the fixes there: https://github.com/cockpit-project/starter-kit/pull/575 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2081432 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
