Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kuftp - Graphical FTP Client for KDE https://bugzilla.redhat.com/show_bug.cgi?id=386531 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-09 10:51 EST ------- For 0.9.1-2: * URL - IMO for sourceforge hosted project, it is prefer to use URL: http://kuftp.sourceforge.net. * autotool call after configure - build.log says ------------------------------------------------------------- 333 Good - your configure finished. Start make now 334 335 + make -j2 336 cd . && /bin/sh /builddir/build/BUILD/kuftp-0.9.1/admin/missing --run automake-1.9 --gnu 337 /builddir/build/BUILD/kuftp-0.9.1/admin/missing: line 52: automake-1.9: command not found 338 WARNING: `automake-1.9' is missing on your system. You should only need it if 339 you modified `Makefile.am', `acinclude.m4' or `configure.in'. 340 You might want to install the `Automake' and `Perl' packages. 341 Grab them from any GNU archive site. -------------------------------------------------------------- http://koji.fedoraproject.org/koji/getfile?taskID=283496&name=build.log Having autotools called automatically is not desired. Generally this means that some files have unwilling timestamps and can be fixed by "touch"ing some files. * Directory ownership issue - For example -------------------------------------------------------------- [tasaka1@localhost ~]$ rpm -qf /usr/share/apps/kuftp/kuftpui.rc kuftp-0.9.1-2.fc9 [tasaka1@localhost ~]$ rpm -qf /usr/share/apps/kuftp/ file /usr/share/apps/kuftp is not owned by any package -------------------------------------------------------------- Here /usr/share/apps/kuftp is created by kuftp package to install kuftpui.rc under the directory, however kuftp does not own the directory, which is not right. The %files entry --------------------------------------------------------------- %files %{_datadir}/apps/kuftp/* --------------------------------------------------------------- contains any files/directories/etc under %_datadir/apps/kuftp, but does not contain the directory %_datadir/apps/kuftp itself, where --------------------------------------------------------------- %files %{_datadir}/apps/kuftp/ --------------------------------------------------------------- contains the directory %_datadir/apps/kuftp _and_ all files/ directories/etc under %_datadir/apps/kuftp. * Absolute symlink ---------------------------------------------------------------- $ rpmlint kuftp kuftp.i386: W: symlink-should-be-relative /usr/share/doc/HTML/en/kuftp/common /usr/share/doc/HTML/en/common ---------------------------------------------------------------- - We require that the symlinks must be relative (i.e. ../common), not absolute. As this is SPONSORNEEDED ticket: ------------------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose "Merge Review") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review