https://bugzilla.redhat.com/show_bug.cgi?id=2069413 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|NEW |POST --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > not sure how review bumps work with autospec but they're updated on the original links That's fine with me. > Source2: https://github.com/enarx/ciborium/blob/main/ciborium/LICENSE This is a link to an HTML page on GitHub you probably meant to use the URL to the raw file: Source2: https://github.com/enarx/ciborium/raw/b77f979/ciborium/LICENSE Please fix this before importing the package (and you could use Source1 instead of Source2, since there is no Source1). You can also drop this (now inaccurate) comment from the .spec file's %files section: # FIXME: no license files detected And please use "%license %{crate_instdir}/LICENSE" instead of "%license LICENSE". This will result in the file being included only once in the built RPM files instead of twice. That string also matches what will be generated once the published crate will contain the LICENSE file. But these are all minor issues that you can fix when importing the package, otherwise LGTM. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2069413 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
