[Bug 2076374] Review Request: trafficserver - Fast, scalable and extensible HTTP/1.1 and HTTP/2 caching proxy server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2076374



--- Comment #26 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Jered Floyd from comment #23)
> > > [!]: Fully versioned dependency in subpackages if applicable.
> > >      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
> > >      trafficserver-selinux , trafficserver-devel , trafficserver-perl
> > 
> > The selinux subpackage is fine as-is, but the rest need their "%{name} =
> > %{version}-%{release}" dependency updated to "%{name}%{?_isa} =
> > %{version}-%{release}".
> 
> For trafficserver-perl, would it actually be more correct to add:
> 
>    BuildArch:           noarch
> 
> rather than adding the architecture to the dependencies?

Yes. I also just noticed you should probably be using "%{perl_vendorlib}"
instead of "%{_datadir}/perl5" in your file lists.

You need to add BuildRequires for perl-generators and perl-interpreter too.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2076374
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux