https://bugzilla.redhat.com/show_bug.cgi?id=2078592 --- Comment #6 from Petr Menšík <pemensik@xxxxxxxxxx> --- (In reply to Chris Snyder from comment #5) > Thank you very much for the review!! > > I'm not sure I see the benefit of adding the %config directive for these > files which are not intended to be modified by the user. > We can consider moving the pem files to another directory but it is worth > mentioning that this directory is used by katello and related tooling to add > *.pem files for use in communicating with foreman / Satellite instances so > unless it is a blocking item I'd rather continue that discussion with those > folks as well after the addition of this package. > > To address the ownership of the /etc/rhsm directory I've opened this PR > against subscription-manager: > https://github.com/candlepin/subscription-manager/pull/3045 > > What are the next steps? If they are never intended to be modified, they belong to /usr/share instead. I think every file under %_sysconfdir should be marked either %config or %config(noreplace). Please mark it as %config, it would keep the behaviour on updates, but possible user's changed won't be lost forever. If those certs should never be updated manually, then they should be moved to /usr/share and only symlinks provided for backward compatiblity. Please choose one of approaches, but I don't think non-backed up files belong anywhere to /etc. Note: guidelines make it clear they *must* be marked config files. It is not only should, therefore I would give release+ if they are either config files or just links to /usr dir. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2078592 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
