[Bug 2080029] Review Request: rEFInd - User friendly EFI boot manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2080029



--- Comment #5 from Davide Cavalca <dcavalca@xxxxxx> ---
- there's a few bundled libraries (nanojpeg, lodepng, possibly others) that
aren't under GPLv3. These should probably be declared (as I don't think they'd
be easy to unbundle) and the license field updated.
- consider splitting the docs in a subpackage (rpmlint also complains about
that, not sure why fedora-review didn't pick that up)
- use make %{?_smp_mflags} or add a comment if that doesn't work
- add a comment to explain why we're disabling LTO
- nit: you don't need to mkdir if you're using install -D (e.g. for man8)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2080029
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux