https://bugzilla.redhat.com/show_bug.cgi?id=2073825 Iztok Fister Jr. <iztok@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(iztok@iztok-jr-fi | |ster.eu) | --- Comment #2 from Iztok Fister Jr. <iztok@xxxxxxxxxxxxxxxxxx> --- Thank you very much for your review. I am responding with my answers to your comments. Both files were also updated according to your requirements. ALL ISSUES:: Comment: - I can’t find anything licensed CC-BY-SA in the package. If (MIT and CC-BY-SA) is really the correct License, you need to to add a licensing breakdown comment as in https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios. ANSWER: Yes. You are right; only the MIT license should be written down. Comment: Version 0.1.6 is available; please update. ANSWER: Done Comment: - You can remove BuildRequires: %{py3_dist sphinx} BuildRequires: %{py3_dist sphinx-rtd-theme} BuildRequires: %{py3_dist sphinxcontrib-bibtex} and instead change %pyproject_buildrequires -r to (noting that you could leave “-r”, but I have dropped it because it is now the default): %pyproject_buildrequires %{?with_doc_pdf:-x docs} ANSWER: Done Optional issues: - Tests: I will do it later when the package is imported. - Man pages: I will ask you to provide a man page. However, the package is now under heavy development, and major changes are expected. Hence, we may wait for one more month. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2073825 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
