[Bug 1991164] Review Request: rust-libsodium-sys - FFI binding to libsodium

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1991164



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
The changes that are required to make this work well as a distro package don't
look too bad:

1) Patch the build.rs file according to these rules:
- remove all blocks that are gated behind #[cfg(not(feature =
"use-pkg-config"))]
- remove #[cfg(feature = "use-pkg-config)] attributes to make those blocks
compile unconditionally

2) Do "rm -r libsodium" between %prep and %cargo_prep.

This should ensure that the crate always dynamically links against the system
copy of libsodium, whether during its own build or while it's being compiled as
dependency for another crate.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1991164
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux