Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: WebKit - Web content engine library Alias: WebKit https://bugzilla.redhat.com/show_bug.cgi?id=415211 ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2007-12-07 16:22 EST ------- (In reply to comment #2) > MUST: > > X rpmlint must be silent > E: only-non-binary-in-usr-lib, i am not sure what this means. This is ignorable, as the devel subpackages contain only the DSO symlink, header files, and some other build data (such as a pkgconfig file). > X make sure lines are <= 80 characters > PROMBLEM : Some lines are longer than 80 chars. Everything that is user-visible is within the 80-char limit; and the only things that are not are long path names and such whose split would make it even more messy, which I'd hate to do. > X %defattrs present ( %defattr(-, root, root, -)) > PROBLEM : %defattr(-,root,root,-) is missing in qt & qt-devel %files section. Oopsie; I fixed this in the 0.3 release. (In reply to comment #3) > I just tried to rebuild on dist-f9, however it failed at least on > ppc. > http://koji.fedoraproject.org/koji/taskinfo?taskID=281420 Gaah, stupid assembly in the spinlocking. Sorry about that. I've added a patch which forces use of the pthread implementation instead of handcoded ASM. That seems to have fixed it: http://koji.fedoraproject.org/koji/taskinfo?taskID=282220(In reply to comment #4) (In reply to comment #4) > Be aware, if you choose to include qt(4) support here, it will (likely?) be > short-lived. WebKit is slated to be included in qt-4.4 proper. Ah, I didn't about its inclusion plan for Qt 4.4; but when that is released, it should be a simple enough effort to Obsoletes/Provides the WebKit-qt and WebKit-qt-devel packages for a smooth upgrade. :) Updated spec: http://pgordon.fedorapeople.org/for-review/WebKit.spec Updated SRPM: http://pgordon.fedorapeople.org/for-review/WebKit-1.0.0-0.3.svn28482.fc8.src.rpm * Thu Dec 06 2007 Peter Gordon <peter@xxxxxxxxxxxxxxxx> 1.0.0-0.3.svn28482 - Add proper %%defattr line to qt, qt-devel, and doc subpackages. - Add patch to forcibly build the TCSpinLock code using the pthread implementation: + TCSpinLock-use-pthread-stubs.patch Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review