https://bugzilla.redhat.com/show_bug.cgi?id=2051047 Onuralp Sezer <thunderbirdtr@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Onuralp Sezer <thunderbirdtr@xxxxxxxxx> --- We can change add those files into our src.fpo website so it won't give error, build-id is fine. Licenses are looks good to me Also could you modify file section for consistency of variable usage. you use "koko" and "%{name}" so please replace %{_kf5_qmldir}/org/kde/koko/* <-- can be change %{_kf5_datadir}/koko <--- can be change If app name decide to change their name or something It will be consistent, minimal to work. Rest of them looks good. I approve the package but please do the changes in final spec file. Thank you Package approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2051047 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
