[Bug 2073377] Review Request: perl-Parse-Distname - Parse a distribution name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2073377



--- Comment #3 from Michal Josef Spacek <mspacek@xxxxxxxxxx> ---
(In reply to Paul Howarth from comment #2)
> (In reply to Michal Josef Spacek from comment #1)
> > @paul@xxxxxxxxxxxx 
> > 
> > "BuildRequires:  coreutils"
> > It is not needed, sure?
> 
> %{_fixperms} in the %install section is implemented using chmod from
> coreutils.

Ah, ok.

> > "%doc Changes README t/"
> > No contain t/ in doc
> 
> I don't usually package the tests. It's a habit from a long time ago when
> you could get additional dependencies from documentation files.
> I'm open to persuasion on this.

That's no about test packaging. We don't package test files in main package.
I use grep to mine packages and there is no case for it.

Option is only extra package for tests.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2073377
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux