https://bugzilla.redhat.com/show_bug.cgi?id=2049772 Yaroslav Sidlovsky <zawertun@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #2 from Yaroslav Sidlovsky <zawertun@xxxxxxxxx> --- All in all spec looks good expect this: 1. I think it will be better to change License tag to "GPLv2 and GPLv3+" to reflect bundled libs licenses; 2. %post script reloading udev rules is not needed, rules would be reloaded automatically (see: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/thread/P7NHGIP3VKWOMVHET5QMEPYMQWVIWO56/) 3. LICENSE file should belong to main package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2049772 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
