[Bug 2076455] Review Request: golang-github-twpayne-pinentry - Provides a client to GnuPG's pinentry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2076455

Fabio Alessandro Locati <me@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
             Status|NEW                         |ASSIGNED
                 CC|                            |me@xxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |me@xxxxxxx



--- Comment #1 from Fabio Alessandro Locati <me@xxxxxxx> ---
Hi Carmelo,

Thanks for the effort, and overall a good package!

In theory the `BuildRequires: golang(github.com/golang/mock/gomock)` should not
be needed, but I think there is an issue on the mock package, which is
hopefully solved by
https://src.fedoraproject.org/rpms/golang-github-mock/pull-request/1, so for
now we can keep it and remove it once the problem is solved.

I see a one thing to tweak before it's approvable:

The shipped binary (gen) only utility is to generate the source code, so we do
not need to have it within the package, since we are already ship the output of
it.

To strip the binary you should:
* Add after `%bcond_without check` the configuration to let the builder know to
produce platform-independent RPM, since we are only going to ship sources:

   %global debug_package %{nil}


* Remove the build of the binary:

    for cmd in cmd/*; do
      %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
    done

* Remove the installation of the binary and respective folder:

    install -m 0755 -vd                     %{buildroot}%{_bindir}
    install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/

* Since we only need to put files in the -devel package, we can also remove the
whole %file block since %gopkgfiles will take care of all files and put them in
the right location without help:

    %files
    %license LICENSE
    %doc README.md
    %{_bindir}/*


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2076455
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux