https://bugzilla.redhat.com/show_bug.cgi?id=2042998 --- Comment #8 from Petr Menšík <pemensik@xxxxxxxxxx> --- I would change library pattern in main package to: %{_libdir}/libsysrepo.so.7* I would remin the developer when this does not match anymore that dependent packages needs rebuild also. As a minor thing %{_libdir}/libsysrepo.so is also part of main package, but it should be only in devel subpackage. Anything that needs to link with sysrepo should have BuildRequires: sysrepo-devel. sysrepo should not work alone. %{_sysconfdir}/sysrepo should be created in %install section with appropriate group. It does not belong to %post script. %attr(0770,root,sysrepo) %{_sysconfdir}/sysrepo # put into %files I am not sure %postun deletion of shm files is required. I am not sure, but wouldn't they be autoremoved as soon as dependent application stops? Shouldn't any dependent application or daemon shutdown on uninstallation? I think dependencies should force any dependent packages to stop their users, so nothing should remain here. Not sure, I don't maintain any package using shm. And please add this bug to bodhi updates with sysrepo builds. It would get closed once they get into stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2042998 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
