Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Class-Accessor-Grouped - Lets you build groups of accessors https://bugzilla.redhat.com/show_bug.cgi?id=411511 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-12-06 20:38 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But NOT for RPM. ==>see comment#3 + source files match upstream url e38f47b4732df2e3af1cdcea035f9b2b Class-Accessor-Grouped-0.07000.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/*/*.t t/accessors........ok t/accessors_ro.....ok t/accessors_wo.....ok t/basic............ok t/component........ok t/inherited........ok t/manifest.........skipped all skipped: set TEST_AUTHOR to enable this test t/pod_coverage.....skipped all skipped: set TEST_AUTHOR to enable this test t/pod_spelling.....skipped all skipped: set TEST_AUTHOR to enable this test t/pod_syntax.......skipped all skipped: set TEST_AUTHOR to enable this test t/strict...........skipped all skipped: set TEST_AUTHOR to enable this test t/style_no_tabs....skipped all skipped: set TEST_AUTHOR to enable this test t/warnings.........skipped all skipped: set TEST_AUTHOR to enable this test All tests successful, 7 tests skipped. Files=13, Tests=188, 1 wallclock secs ( 0.60 cusr + 0.16 csys = 0.76 CPU) + Package perl-Class-Accessor-Grouped-0.07000-1.fc9 -> Provides: perl(Class::Accessor::Grouped) = 0.07000 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Class::Inspector) perl(MRO::Compat) perl(Scalar::Util) perl(strict) perl(vars) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review