https://bugzilla.redhat.com/show_bug.cgi?id=2068909 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxx --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > BuildRequires: redhat-rpm-config > BuildRequires: cmake-rpm-macros Are you sure these are needed? I don't think I've ever seen a package explicitly BuildRequiring them. > License: GPLv2 Looking through the sources, the license headers in .h files say: > either version 2 of the License, or (at your option) any later version So this should be "GPLv2+". > %files > %{_cups_serverbin}/filter/rastertobrlaser > %{_datadir}/cups/drv/brlaser.drv > %doc README.md The COPYING file is not installed. Also, the build process includes building some tests, but, looking at the build log, these don't seem to be executed. Please add: > %check > %ctest To the spec, or consider patching the CMakeLists.txt so the tests aren't built. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2068909 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
