https://bugzilla.redhat.com/show_bug.cgi?id=2072115 --- Comment #3 from Sandro Mani <manisandro@xxxxxxxxx> --- Full review below, comments: - License MIT seems to correctly reflect the contents of the binary package. util/sch_htb-ofbuf/* is GPLv2+, but is not built. - [x]: %build honors applicable compiler flags or justifies otherwise. => As of F36 (see https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck), CFLAGS/LDFLAGS etc are set by default. You could omit export CC="gcc %{optflags}". If you keep it, the correct way would be export CC=gcc export CFLAGS="%{optflags}" export LDFLAGS="%{__global_ldflags}" - [x]: Requires correct, justified where necessary. => It might be useful to add a comment explaining the requires - [!]: Packages should try to preserve timestamps of original installed files. => Use install -p - rpmlint: drop exec bit from manpages, drop shebang from topo.py, review examples: either add exec bit or drop shebang depending on whether they should be runnable as python scripts or only used as imported python modules Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "MIT License", "*No copyright* [generated file]", "*No copyright* GNU General Public License v2.0 or later". 134 files have unknown license. Detailed output of licensecheck in /home/sandro/Desktop/2072115-mininet/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- mininet.x86_64: W: spurious-executable-perm /usr/share/man/man1/mn.1.gz mininet.x86_64: W: spurious-executable-perm /usr/share/man/man1/mnexec.1.gz mininet-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/mnexec-2.3.0-1.fc37.x86_64.debug mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/baresshd.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/bind.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/cluster.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/clusterSanity.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/clustercli.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/clusterdemo.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/clusterperf.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/consoles.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/controllers.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/controllers2.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/controlnet.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/cpu.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/emptynet.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/hwintf.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/intfoptions.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/limit.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/linearbandwidth.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/linuxrouter.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/miniedit.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/mobility.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/multilink.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/multiping.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/multipoll.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/multitest.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/nat.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/natnet.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/numberedports.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/popen.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/popenpoll.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/scratchnet.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/scratchnetuser.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/simpleperf.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/sshd.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/tree1024.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/treeping64.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/examples/vlanhost.py 644 /usr/bin/env python mininet.x86_64: E: non-executable-script /usr/lib/python3.10/site-packages/mininet/topo.py 644 /usr/bin/env python Source checksums ---------------- https://github.com/mininet/mininet/archive/2.3.0/mininet-2.3.0.tar.gz : CHECKSUM(SHA256) this package : 1b16ee53ddb9a34a3751a77517643bda2286fc31be123209e84884d0697107b0 CHECKSUM(SHA256) upstream package : 1b16ee53ddb9a34a3751a77517643bda2286fc31be123209e84884d0697107b0 Requires -------- mininet (rpmlib, GLIBC filtered): /usr/bin/python3 ethtool iperf iproute libc.so.6()(64bit) libcgroup-tools net-tools openssh-clients openvswitch procps-ng psmisc python(abi) python3.10dist(setuptools) rtld(GNU_HASH) socat telnet which xterm mininet-debuginfo (rpmlib, GLIBC filtered): mininet-debugsource (rpmlib, GLIBC filtered): Provides -------- mininet: mininet mininet(x86-64) python3.10dist(mininet) python3dist(mininet) mininet-debuginfo: debuginfo(build-id) mininet-debuginfo mininet-debuginfo(x86-64) mininet-debugsource: mininet-debugsource mininet-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2072115 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Python, Shell-api Disabled plugins: Java, PHP, Haskell, Perl, SugarActivity, R, Ruby, Ocaml, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072115 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
